Go 1.17 prep - ignore vendor directory in staticcheck #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few vendored dependencies have benign staticcheck errors when using Go 1.17. This commit simply filters out vendor directories in staticcheck output since the intention of the linter is to check Fabric source only. Note - it is not possible to filter the vendor directories as input to staticcheck, as they will still show up when the Fabric package that uses them gets checked. Have to filter the output instead. Signed-off-by: David Enyeart <enyeart@us.ibm.com>
andrew-coleman
approved these changes
Dec 13, 2021
Closed
denyeart
added a commit
to denyeart/fabric
that referenced
this pull request
Jan 20, 2022
A few vendored dependencies have benign staticcheck errors when using Go 1.17. This commit simply filters out vendor directories in staticcheck output since the intention of the linter is to check Fabric source only. Note - it is not possible to filter the vendor directories as input to staticcheck, as they will still show up when the Fabric package that uses them gets checked. Have to filter the output instead. Signed-off-by: David Enyeart <enyeart@us.ibm.com>
andrew-coleman
pushed a commit
that referenced
this pull request
Jan 25, 2022
* Go 1.17 prep - ignore vendor directory in staticcheck (#3114) A few vendored dependencies have benign staticcheck errors when using Go 1.17. This commit simply filters out vendor directories in staticcheck output since the intention of the linter is to check Fabric source only. Note - it is not possible to filter the vendor directories as input to staticcheck, as they will still show up when the Fabric package that uses them gets checked. Have to filter the output instead. Signed-off-by: David Enyeart <enyeart@us.ibm.com> * Bump Go to 1.17.5 Bump Go to 1.17.5. Fix unit tests to work with Go 1.17.5. Update dependencies to work with Go 1.17. Signed-off-by: David Enyeart <enyeart@us.ibm.com> * Use upgraded deps Signed-off-by: Alessandro Sorniotti <aso@zurich.ibm.com> Co-authored-by: Alessandro Sorniotti <aso@zurich.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few vendored dependencies have benign staticcheck errors
when using Go 1.17.
This commit simply filters out vendor directories in staticcheck output
since the intention of the linter is to check Fabric source only.
Note - it is not possible to filter the vendor directories as input to staticcheck,
as they will still show up when the Fabric package that uses them gets checked.
Have to filter the output instead.
Signed-off-by: David Enyeart enyeart@us.ibm.com